Review Request 114640: Implements volume percentage indicator

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114640/#review46591
-----------------------------------------------------------


Thanks for your patch. It looks very simple and non-invasive. For integration it needs some additions and changes, though:
1) It needs to be configurable, thus an option in the configuration dialog is required. Default is off.
2) There is some duplicated code for creating the QLabel in vertical and horizontal mode. Could you unify it, like I just did for the other parts in MDWSLider?
3) setMinimumWidth(QLabel("100").sizeHint().width() * 2) : Isn't doubled width a bit wide?


- Christian Esken


On Dec. 24, 2013, 9:20 a.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114640/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2013, 9:20 a.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> see bug 320949
> 
> 
> Diffs
> -----
> 
>   gui/mdwslider.h 09d847f 
>   gui/mdwslider.cpp e169a02 
> 
> Diff: https://git.reviewboard.kde.org/r/114640/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140102/3262b774/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia