<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114640/">https://git.reviewboard.kde.org/r/114640/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for your patch. It looks very simple and non-invasive. For integration it needs some additions and changes, though:
1) It needs to be configurable, thus an option in the configuration dialog is required. Default is off.
2) There is some duplicated code for creating the QLabel in vertical and horizontal mode. Could you unify it, like I just did for the other parts in MDWSLider?
3) setMinimumWidth(QLabel("100").sizeHint().width() * 2) : Isn't doubled width a bit wide?
</pre>
<br />
<p>- Christian Esken</p>
<br />
<p>On December 24th, 2013, 9:20 a.m. UTC, Arjun Ak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2013, 9:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmix
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see bug 320949</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/mdwslider.h <span style="color: grey">(09d847f)</span></li>
<li>gui/mdwslider.cpp <span style="color: grey">(e169a02)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114640/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>