Review Request 115957: Port the Cover dialog from K3ListView and Q3IconView to KListWidget.

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115957/#review50561
-----------------------------------------------------------

Ship it!


This seems to work well and the code looks good.

I'll note that I'm starting to be of the opinion that this entire feature should be killed off anyways; once I added support for viewing album art embedded into the files themselves I don't think I ever used this code again. For future development it would probably be best to extend our album art code to be able to replace embedded album art in the music files themselves rather than use a separate cover manager, but that's something for a later date.


covericonview.cpp
<https://git.reviewboard.kde.org/r/115957/#comment35565>

    Generally if you're commenting out entire blocks of code, it's better to use '#if 0' and terminate with '#endif'.
    
    This construct is understood by fancier editors like vim and kate, and there's no risk of accidentally having the comment end to early because a '*/' is present somewhere within the block.


- Michael Pyne


On Feb. 22, 2014, 7:24 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115957/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 7:24 p.m.)
> 
> 
> Review request for KDE Multimedia, Michael Pyne and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> Port the Cover dialog from K3ListView and Q3IconView to KListWidget. The Drag'n'drop thing is still to be done, unfortunately.
> 
> 
> Diffs
> -----
> 
>   coverdialog.h a002c00 
>   coverdialog.cpp 39d4f6e 
>   coverdialogbase.ui afaf12b 
>   covericonview.h 26fe10e 
>   covericonview.cpp 499c58c 
> 
> Diff: https://git.reviewboard.kde.org/r/115957/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140223/b3eb673b/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia