<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115957/">https://git.reviewboard.kde.org/r/115957/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems to work well and the code looks good.
I'll note that I'm starting to be of the opinion that this entire feature should be killed off anyways; once I added support for viewing album art embedded into the files themselves I don't think I ever used this code again. For future development it would probably be best to extend our album art code to be able to replace embedded album art in the music files themselves rather than use a separate cover manager, but that's something for a later date.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115957/diff/1/?file=245592#file245592line48" style="color: black; font-weight: bold; text-decoration: underline;">covericonview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/* Q3DragObject *CoverIconView::dragObject()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Generally if you're commenting out entire blocks of code, it's better to use '#if 0' and terminate with '#endif'.
This construct is understood by fancier editors like vim and kate, and there's no risk of accidentally having the comment end to early because a '*/' is present somewhere within the block.</pre>
</div>
<br />
<p>- Michael Pyne</p>
<br />
<p>On February 22nd, 2014, 7:24 p.m. UTC, Arnold Dumas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia, Michael Pyne and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Arnold Dumas.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2014, 7:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
juk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port the Cover dialog from K3ListView and Q3IconView to KListWidget. The Drag'n'drop thing is still to be done, unfortunately.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>coverdialog.h <span style="color: grey">(a002c00)</span></li>
<li>coverdialog.cpp <span style="color: grey">(39d4f6e)</span></li>
<li>coverdialogbase.ui <span style="color: grey">(afaf12b)</span></li>
<li>covericonview.h <span style="color: grey">(26fe10e)</span></li>
<li>covericonview.cpp <span style="color: grey">(499c58c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115957/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>