Review Request 121731: Make Juk mpris2 metadata closer match vlc / dragon / amarok metadata with empty fields

James Smith smithjd15 at gmail.com
Sun Dec 28 23:52:53 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121731/
-----------------------------------------------------------

Review request for KDE Multimedia.


Repository: juk


Description
-------

Juk behaviour with empty metadata fields was to include the field irregardless of whether it was empty or not. This patch follows vlc, dragon, and amarok behaviour which is to just omit the field when there is no information.


Diffs
-----

  mpris2/mediaplayer2player.cpp 080b43fe2b47fa2b0f2e37ad15695bfcf33efe5e 

Diff: https://git.reviewboard.kde.org/r/121731/diff/


Testing
-------

Compile, run. Test with files with appropriate metadata characteristics.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20141228/e59120b0/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list