Review Request 121725: Fix kmix tray icon scrolling
Xuetian Weng
wengxt at gmail.com
Sun Dec 28 22:41:13 GMT 2014
> On Dec. 28, 2014, 9:37 p.m., Kai Uwe Broulik wrote:
> > Shouldn't this rather be fixed in systray only forwarding single ticks to apps? I suppose most apps break with high precision scrolling in that regard, many of which are not under our control.
SNI interface is designed to have the "delta" argument.
http://www.notmart.org/misc/statusnotifieritem/statusnotifieritem.html
- Xuetian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121725/#review72627
-----------------------------------------------------------
On Dec. 28, 2014, 9 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121725/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2014, 9 p.m.)
>
>
> Review request for KDE Multimedia and Christian Esken.
>
>
> Bugs: 313579 and 341536
> http://bugs.kde.org/show_bug.cgi?id=313579
> http://bugs.kde.org/show_bug.cgi?id=341536
>
>
> Repository: kmix
>
>
> Description
> -------
>
> High-precision scroll is going to send scroll event with multiple small delta event. A simple way to fix it is to round it by 120 for a single increment.
>
> The problem in 313579 is that the delta value is directly divided by 120. This patch add all delta value up and round it by 120.
>
>
> Diffs
> -----
>
> gui/kmixdockwidget.h a0d7a46
> gui/kmixdockwidget.cpp eeccb36
>
> Diff: https://git.reviewboard.kde.org/r/121725/diff/
>
>
> Testing
> -------
>
> Plasma 5 + kmix scroll with trackpad.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20141228/e79b93ec/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list