Review Request 112433: Use operator bool() instead of != and == for shared_ptr.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112433/
-----------------------------------------------------------

(Updated Sept. 3, 2013, 10 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia and Christian Esken.


Description
-------

(This is part 1 of 2 of the shared_ptr changes)

In preparation for supporting C++11's version of shared_ptr, convert
some
comparisons to operator bool(), that is

  if (foo != 0) becomes if (foo)
  if (foo == 0) becomes if (!foo)

as otherwise the build (with clang and libc++) would fail because there
is
no overload for operator==(shared_ptr, int) and operator!=(shared_ptr,
int).


Diffs
-----

  apps/kmixd.cpp 442abaf89b65f96382bf954e6cb592d61ff12b12 
  backends/mixer_backend.cpp 2e2e901552ec6213e66ffeb735e896f32563cb04 
  backends/mixer_mpris2.cpp 6ebcd8fcdb038d51d196356230070ccc634230e0 
  core/mixertoolbox.cpp 60c9fc8788cbe0c73efcad0e3291bafa20f8bdc7 
  gui/kmixdockwidget.cpp 47e807337f46e67750174c6fc5f938fc889a089c 
  gui/viewdockareapopup.cpp 48411bd161601b5301ba471a1f8103e4c40017dd 

Diff: http://git.reviewboard.kde.org/r/112433/diff/


Testing
-------

Together with <https://git.reviewboard.kde.org/r/112434> building KMix with clang and libc++ finally succeeds.


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130903/54ea3a6a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia