<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112433/">http://git.reviewboard.kde.org/r/112433/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2013, 10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(This is part 1 of 2 of the shared_ptr changes)
In preparation for supporting C++11's version of shared_ptr, convert
some
comparisons to operator bool(), that is
if (foo != 0) becomes if (foo)
if (foo == 0) becomes if (!foo)
as otherwise the build (with clang and libc++) would fail because there
is
no overload for operator==(shared_ptr, int) and operator!=(shared_ptr,
int).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Together with <https://git.reviewboard.kde.org/r/112434> building KMix with clang and libc++ finally succeeds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>apps/kmixd.cpp <span style="color: grey">(442abaf89b65f96382bf954e6cb592d61ff12b12)</span></li>
<li>backends/mixer_backend.cpp <span style="color: grey">(2e2e901552ec6213e66ffeb735e896f32563cb04)</span></li>
<li>backends/mixer_mpris2.cpp <span style="color: grey">(6ebcd8fcdb038d51d196356230070ccc634230e0)</span></li>
<li>core/mixertoolbox.cpp <span style="color: grey">(60c9fc8788cbe0c73efcad0e3291bafa20f8bdc7)</span></li>
<li>gui/kmixdockwidget.cpp <span style="color: grey">(47e807337f46e67750174c6fc5f938fc889a089c)</span></li>
<li>gui/viewdockareapopup.cpp <span style="color: grey">(48411bd161601b5301ba471a1f8103e4c40017dd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112433/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>