Review Request 113412: Fix VolumeSlider by exporting PULSE_PROP_OVERRIDE_phonon.streamId

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113412/
-----------------------------------------------------------

(Updated Oct. 24, 2013, 3:32 p.m.)


Status
------

This change has been discarded.


Review request for Phonon and Harald Sitter.


Repository: phonon


Description
-------

The VolumeSlider didn't work for me with Phonon/master. Turned out sink_input_cb in pulsesupport.cpp never set index for the stream, because pa_sink_input_info->proplist did not contain PA_PROP_PHONON_STREAMID property.

By exporting the streamID via PULSE_PROP_OVERRIDE_phonon.streamId in register_stream(), volume control works again. However I'm not sure whether this is the proper way to do it, passing stuff via env variables feels like a dirty hack to me :-)


Diffs
-----

  phonon/pulsesupport.cpp 48c441e 

Diff: http://git.reviewboard.kde.org/r/113412/diff/


Testing
-------

Fiddling with slider changes volume. Also changing volume of the stream in KMix/pavucontrol moves the slider in the application.


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131024/a22094d0/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia