Review Request 113412: Fix VolumeSlider by exporting PULSE_PROP_OVERRIDE_phonon.streamId

[Harald Sitter]

> On Oct. 24, 2013, 1:29 p.m., Harald Sitter wrote:
> > why phonon master doesn't set the streamid explicitly anymore http://quickgit.kde.org/?p=phonon.git&a=commit&h=8b98d4e92c747b44eae0280fc9c271476775a068
> > in particular the backend needs to explicitly call setupStreamEnvironment to get steramid etc.
> > 
> > which for phonon gstreamer is entirely replaced by property setting on the pulseout
> > http://quickgit.kde.org/?p=phonon-gstreamer.git&a=commit&h=17928098f2a71623e1b1de61c06d258e0c8d81e6

in case that's not clear, the review is a no-go as it explicitly was redesigned to not export the override unless requested by the backend


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113412/#review42277
-----------------------------------------------------------


On Oct. 24, 2013, 1:01 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113412/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 1:01 p.m.)
> 
> 
> Review request for Phonon and Harald Sitter.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> The VolumeSlider didn't work for me with Phonon/master. Turned out sink_input_cb in pulsesupport.cpp never set index for the stream, because pa_sink_input_info->proplist did not contain PA_PROP_PHONON_STREAMID property.
> 
> By exporting the streamID via PULSE_PROP_OVERRIDE_phonon.streamId in register_stream(), volume control works again. However I'm not sure whether this is the proper way to do it, passing stuff via env variables feels like a dirty hack to me :-)
> 
> 
> Diffs
> -----
> 
>   phonon/pulsesupport.cpp 48c441e 
> 
> Diff: http://git.reviewboard.kde.org/r/113412/diff/
> 
> 
> Testing
> -------
> 
> Fiddling with slider changes volume. Also changing volume of the stream in KMix/pavucontrol moves the slider in the application.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131024/4df792a2/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia