Review Request 114217: ebn krazy fixes in JuK

Commit Hook null at kde.org
Sat Nov 30 13:33:51 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114217/#review44877
-----------------------------------------------------------


This review has been submitted with commit dde52a0efcd0249c745c2f4b86b461dc299e24cc by Shubham Chaudhary to branch master.

- Commit Hook


On Nov. 30, 2013, 1:29 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114217/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2013, 1:29 p.m.)
> 
> 
> Review request for KDE Multimedia and Michael Pyne.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> Changes: 
> * single quote chars
> * casted floats to qBound
> * KUrl instead of QUrl
> * removed empty spaces
> * added newline at eof
> 
> 
> Diffs
> -----
> 
>   lyricswidget.cpp 56d7778 
>   mpris2/mediaplayer2player.cpp fe9b6b7 
>   scrobbleconfigdlg.h 139b65e 
>   scrobbler.cpp 01661ca 
>   volumepopupbutton.cpp 2608e53 
> 
> Diff: http://git.reviewboard.kde.org/r/114217/diff/
> 
> 
> Testing
> -------
> 
> build and run
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131130/672cfe1d/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list