Review Request 114217: ebn krazy fixes in JuK

Shubham Chaudhary shubhamchaudhary92 at gmail.com
Sat Nov 30 13:29:39 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114217/
-----------------------------------------------------------

(Updated Nov. 30, 2013, 6:59 p.m.)


Review request for KDE Multimedia and Michael Pyne.


Changes
-------

Updated the floats and considering that fromLocalFile is a static function retained the KUrl just to satisfy ebn.


Repository: juk


Description
-------

Changes: 
* single quote chars
* casted floats to qBound
* KUrl instead of QUrl
* removed empty spaces
* added newline at eof


Diffs (updated)
-----

  lyricswidget.cpp 56d7778 
  mpris2/mediaplayer2player.cpp fe9b6b7 
  scrobbleconfigdlg.h 139b65e 
  scrobbler.cpp 01661ca 
  volumepopupbutton.cpp 2608e53 

Diff: http://git.reviewboard.kde.org/r/114217/diff/


Testing
-------

build and run


Thanks,

Shubham Chaudhary

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131130/99a9563a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list