Review Request 108909: Context-menu status-bar toggle

[Andrea Scarpino]

> On May 6, 2013, 10:44 p.m., Andrea Scarpino wrote:
> > src/app/videoWindow.cpp, line 768
> > <http://git.reviewboard.kde.org/r/108909/diff/2/?file=128869#file128869line768>
> >
> >     Please use spaces
> 
> Anmol Ahuja wrote:
>     I'm sorry, I'm not sure where I should add more spacing. Between '!' and '(' ?
>     
>     Should I simply change it to:
>       if( ~mainWindow()->windowState() & Qt::WindowFullScreen )
>     instead?

No no need for that, you just used tabs instead of spaces to indent the if statement.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108909/#review32163
-----------------------------------------------------------


On April 2, 2013, 8:49 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108909/
> -----------------------------------------------------------
> 
> (Updated April 2, 2013, 8:49 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> Added a status-bar toggle to the context menu that's disabled on full-screen.
> 
> 
> Diffs
> -----
> 
>   src/app/mainWindow.h 60dfcf6 
>   src/app/mainWindow.cpp b47e279 
>   src/app/videoWindow.cpp a87715f 
> 
> Diff: http://git.reviewboard.kde.org/r/108909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130508/9b0cdece/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia