Review Request 108909: Context-menu status-bar toggle

[Anmol Ahuja]

> On May 7, 2013, 2:14 a.m., Andrea Scarpino wrote:
> > src/app/mainWindow.cpp, line 389
> > <http://git.reviewboard.kde.org/r/108909/diff/2/?file=128868#file128868line389>
> >
> >     I would put 'Show Statusbar' in the Settings menu instead.

apachelogger suggested I put it in the context-menu instead, based on an irc conversation on #kde-multimedia on Feb 11.


> On May 7, 2013, 2:14 a.m., Andrea Scarpino wrote:
> > src/app/videoWindow.cpp, line 768
> > <http://git.reviewboard.kde.org/r/108909/diff/2/?file=128869#file128869line768>
> >
> >     Please use spaces

I'm sorry, I'm not sure where I should add more spacing. Between '!' and '(' ?

Should I simply change it to:
  if( ~mainWindow()->windowState() & Qt::WindowFullScreen )
instead?


- Anmol


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108909/#review32163
-----------------------------------------------------------


On April 3, 2013, 12:19 a.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108909/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 12:19 a.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> Added a status-bar toggle to the context menu that's disabled on full-screen.
> 
> 
> Diffs
> -----
> 
>   src/app/mainWindow.h 60dfcf6 
>   src/app/mainWindow.cpp b47e279 
>   src/app/videoWindow.cpp a87715f 
> 
> Diff: http://git.reviewboard.kde.org/r/108909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130508/a5c45650/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia