Review Request 110852: kscd: Improve MusicBrainz3 buildsys support

[Richard Lärkäng]

> On July 2, 2013, 11:30 p.m., Christoph Feck wrote:
> > Thanks for your patch. I remember a discussion about porting the code to MusicBrainz version 5 (which is already used by libkcddb), but could not find it. openSUSE currently ships with three MusicBrainz versions already, so it's probably time to move forward.
> > 
> > Any kdemultimedia developer looking for a junior job? :) I think k3b fails to handle MusicBrainz 5, too.
> > 
> > Otherwise, I suggest to commit this, but probably a kdemultimedia developer should approve.
> 
> Richard Lärkäng wrote:
>     Just one comment regarding k3b, AFAIK, it handles MusicBrainz access through libkcddb, and hence k3b does not need to be ported.
> 
> Christoph Feck wrote:
>     > cd extragear/multimedia/k3b
>     > ack -ai brainz | wc -l
>     111
>

My mistake. Looking through the code, it seems that it uses MusicBrainz for lookup of single tracks (while for whole CD's it uses MusicBrainz through libkcddb). So indeed, k3b would need to be ported to libmusicbrainz 5 as well.


- Richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110852/#review35480
-----------------------------------------------------------


On June 6, 2013, 7:48 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110852/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 7:48 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> Improve MusicBrainz3 buildsys support
> - include directory is not used
> - add pkgconfig hints
> 
> 
> This addresses bug 320808.
>     http://bugs.kde.org/show_bug.cgi?id=320808
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8a2a8e5 
>   cmake/FindMusicBrainz3.cmake e4bb814 
> 
> Diff: http://git.reviewboard.kde.org/r/110852/diff/
> 
> 
> Testing
> -------
> 
> Installed libmusicbrainz3 to non-standard include/libdir locations, build succeeds.
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130716/077a1d74/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia