[PATCH] Added --no-ignore-config option for libvlc initialization with config.

[Ivan Chernyavsky]

Dear KDE Multimedia team,

while trying to configure Digikam for my needs, I've encountered a problem with phonon-vlc backend. It was impossible to give any configuration options to libvlc through partially documented (in source code) ~/.config/Phonon/vlc.conf file.

Checking the output of vlc --help, I've found the following strange comment:

      --ignore-config, -no-ignore-config                            
      no configuration option will be loaded nor saved to config file (default enabled)

So I've added a --no-ignore-config after --config in the src/utils/libvlc.cpp and it started to read the configuration.

I've checked this on OpenSUSE 12 (as phonon-backend-vlc 0.6.0-1.4 from packman) and Gentoo (having phonon-backend-vlc 0.6.0-r1).

I can see I'm not the first one hitting this problem: https://bugs.kde.org/show_bug.cgi?id=300853 . However in this bug the resolution is not for this exact issue.

Please find the proposed patch below.

--
  Ivan

In case a configuration file is found in .config/Phonon, libvlc.cpp
tries to feed its name for libvlc initialization. However, by default
libvlc has ignore-config switched *on*, so it needs to be explicitly
disabled.

---
 src/utils/libvlc.cpp |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/utils/libvlc.cpp b/src/utils/libvlc.cpp
index 69d626e..f332df6 100644
--- a/src/utils/libvlc.cpp
+++ b/src/utils/libvlc.cpp
@@ -71,6 +71,7 @@ bool LibVLC::init()
         const QString configFileName = QSettings("Phonon", "vlc").fileName();
         if (QFile::exists(configFileName)) {
             args << QByteArray("--config=").append(QFile::encodeName(configFileName));
+            args << "--no-ignore-config";
         }

         int debugLevel = qgetenv("PHONON_SUBSYSTEM_DEBUG").toInt();
-- 
1.7.3.4

_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia