Review Request: Simplify layout of popup window to allow it grow when a new stream is added

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107822/#review24480
-----------------------------------------------------------


I am a bit reluctant to remove the QWidgetAction, as it was the result of a very lengthy bug hunt through many parts of KDE, including Plasma. See https://bugs.kde.org/show_bug.cgi?id=220621#c27 for the background. And m_dockWidget->deleteLater() is still present.
I will still test the patch, as we definitely need a fix and it is still very attractive to get rid of that strange QWidgetAction construct. Tests will include the following cases:
 a) Without tray icon
 b) With tray icon, without Sound Menu
 c) With tray icon, with Sound Menu


- Christian Esken


On Dec. 20, 2012, 8:20 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107822/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2012, 8:20 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> Eliminate QWidgetAction from popup window that allows popup window to change its size. For instance, when a new stream is added, it grows now.
> 
> This might help to avoid recreation of the View (http://commits.kde.org/kmix/1dfbbeb37fe03ed58b7be8ecdf22b376e3633830) that in turn might help with https://bugs.kde.org/show_bug.cgi?id=311167 ?
> 
> 
> This addresses bug 288637.
>     http://bugs.kde.org/show_bug.cgi?id=288637
> 
> 
> Diffs
> -----
> 
>   gui/kmixdockwidget.h 0109086 
>   gui/kmixdockwidget.cpp 3bda22e 
> 
> Diff: http://git.reviewboard.kde.org/r/107822/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130102/16b901dc/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia