Review Request 112076: Fix bug where monitor won't powersave even with only audio content

[James Smith]

> On Aug. 26, 2013, 9:12 a.m., Harald Sitter wrote:
> > src/app/mainWindow.cpp, line 864
> > <http://git.reviewboard.kde.org/r/112076/diff/5/?file=184675#file184675line864>
> >
> >     the f(bool) signature is not necessary here.
> >     
> >     you can simply use TheStream::hasVideo() inside the supression function as that is what the entire logic depends on anyway.

TheStream::hasVideo() didn't work when I originally attempted a quick patch to fix the issue. Thus I needed to use stateChanged to have the bug fixed.


> On Aug. 26, 2013, 9:12 a.m., Harald Sitter wrote:
> > src/app/mainWindow.cpp, lines 866-887
> > <http://git.reviewboard.kde.org/r/112076/diff/5/?file=184675#file184675line866>
> >
> >     no unrelated format changes please

Should I have a separate patch then to fix some of the style issues or just leave it after the bulk of the issues have been ironed out?


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112076/#review38595
-----------------------------------------------------------


On Aug. 26, 2013, 6:53 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112076/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 6:53 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Description
> -------
> 
> Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off.
> 
> 
> Diffs
> -----
> 
>   src/app/stateChange.cpp 0edde72 
>   src/app/mainWindow.cpp f850820 
>   src/app/mainWindow.h 51ef72c 
> 
> Diff: http://git.reviewboard.kde.org/r/112076/diff/
> 
> 
> Testing
> -------
> 
> Compile, run-test
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130826/410570c5/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia