Review Request 112076: Fix bug where monitor won't powersave even with only audio content

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112076/#review38595
-----------------------------------------------------------



src/app/mainWindow.cpp
<http://git.reviewboard.kde.org/r/112076/#comment28544>

    the f(bool) signature is not necessary here.
    
    you can simply use TheStream::hasVideo() inside the supression function as that is what the entire logic depends on anyway.



src/app/mainWindow.cpp
<http://git.reviewboard.kde.org/r/112076/#comment28545>

    no unrelated format changes please



src/app/mainWindow.cpp
<http://git.reviewboard.kde.org/r/112076/#comment28543>

    "listening to audio" sounds better



src/app/stateChange.cpp
<http://git.reviewboard.kde.org/r/112076/#comment28542>

    changes to stateChange.cpp should be discarded (see comment regarding mainWindow).


- Harald Sitter


On Aug. 26, 2013, 6:53 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112076/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 6:53 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Description
> -------
> 
> Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off.
> 
> 
> Diffs
> -----
> 
>   src/app/stateChange.cpp 0edde72 
>   src/app/mainWindow.cpp f850820 
>   src/app/mainWindow.h 51ef72c 
> 
> Diff: http://git.reviewboard.kde.org/r/112076/diff/
> 
> 
> Testing
> -------
> 
> Compile, run-test
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130826/6213f291/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia