Review the patch

[Shubham Chaudhary]

I think QStrings are more efficient that normal strings. And I just noticed
that I wasn't working on the latest version. These changes are already
there in latest master.
Anyhow thanks for helping me out.


On Thu, Apr 11, 2013 at 3:34 PM, Harald Sitter <sitter at kde.org> wrote:

> On Thu, Apr 11, 2013 at 7:25 AM, Shubham Chaudhary <
> shubhamchaudhary92 at gmail.com> wrote:
>
>> This patch shifts char* strings to QString.
>>
>
> why?
>
> also the changes related to KMixToolBox are simply wrong. the string there
> is an internal identifier and does not need to be QString it most
> importantly however does not need to be i18n!
>
> HS
>
> _______________________________________________
> kde-multimedia mailing list
> kde-multimedia at kde.org
> https://mail.kde.org/mailman/listinfo/kde-multimedia
>
>


-- 
Regards,
Shubham Chaudhary
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130412/44d81166/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia