Review the patch

[Harald Sitter]

On Thu, Apr 11, 2013 at 7:25 AM, Shubham Chaudhary <
shubhamchaudhary92 at gmail.com> wrote:

> This patch shifts char* strings to QString.
>

why?

also the changes related to KMixToolBox are simply wrong. the string there
is an internal identifier and does not need to be QString it most
importantly however does not need to be i18n!

HS
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130411/b9f85490/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia