Review Request: Fix ObjectDescriptionModel<*>::staticMetaObject initialization on Qt5.

[David Faure]

> On Oct. 31, 2012, 4:16 p.m., Jon Severinsson wrote:
> > Over a week and still no comments. If no one objects in the next few days, I'm simply gonna push this without any "Ship It!".

I can't really review this code (without much research), but I completely support this "let's not let the fixes die for lack of review" strategy.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106976/#review21246
-----------------------------------------------------------


On Oct. 21, 2012, 11:43 a.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106976/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2012, 11:43 a.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> The internals of QMetaObject has changed in Qt5, so we need two move
> the initialization into two different macros, one for Qt4 and one for Qt5.
> The generated C++ code will be the same after post processing on Qt4, so
> it shouldn't break anything, but it has only been compile tested on Qt5...
> 
> 
> Diffs
> -----
> 
>   phonon/objectdescriptionmodel.cpp fd903ae 
> 
> Diff: http://git.reviewboard.kde.org/r/106976/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121031/846bba1c/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel