Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

[Jon Severinsson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106974/
-----------------------------------------------------------

(Updated Oct. 31, 2012, 4:21 p.m.)


Review request for KDE Frameworks and Phonon.


Changes
-------

Over a week since I uploaded a patch that tries to adress all prior review comments, and I have yet to get new comments. If no one objects in the next few days, I'm simply gonna push this without any "Ship It!", so I can push "Drop KDE_NO_PHONON hackery from KDE Frameworks" to KDE Frameworks 5.


Summary (updated)
-----------------

Rework MediaSource(const QString &filename) constructor in phonon five.


Description (updated)
-------

QFSFileEngine has been removed from Qt5, so the MediaSource(const QString &filename) constructor has to be reworked to not need it.  The only behaviourial changes from the original code are that non-local absolute file paths (eg smb share file paths such as "//hostname/share/path") and "qrc:///" URLs actually works.

I have also added qrc support to the QUrl constructor, and deprecated the QString constructor in favour of it.


Diffs
-----

  phonon/mediasource.h 5374f00 
  phonon/mediasource.cpp 9e35094 

Diff: http://git.reviewboard.kde.org/r/106974/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121031/04a6ea75/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel