Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

Jon Severinsson jon at
Wed Oct 31 16:21:35 GMT 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 31, 2012, 4:21 p.m.)

Review request for KDE Frameworks and Phonon.


Over a week since I uploaded a patch that tries to adress all prior review comments, and I have yet to get new comments. If no one objects in the next few days, I'm simply gonna push this without any "Ship It!", so I can push "Drop KDE_NO_PHONON hackery from KDE Frameworks" to KDE Frameworks 5.

Summary (updated)

Rework MediaSource(const QString &filename) constructor in phonon five.

Description (updated)

QFSFileEngine has been removed from Qt5, so the MediaSource(const QString &filename) constructor has to be reworked to not need it.  The only behaviourial changes from the original code are that non-local absolute file paths (eg smb share file paths such as "//hostname/share/path") and "qrc:///" URLs actually works.

I have also added qrc support to the QUrl constructor, and deprecated the QString constructor in favour of it.


  phonon/mediasource.h 5374f00 
  phonon/mediasource.cpp 9e35094 




Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
Kde-frameworks-devel mailing list
Kde-frameworks-devel at

More information about the kde-multimedia mailing list