Review Request: Remove QFSFileEngine useage from Phonon five.

Jon Severinsson jon at
Sun Oct 21 15:00:57 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 21, 2012, 2 p.m.)

Review request for KDE Frameworks and Phonon.


OK, new try. This implementation is even ugglier, but closer to the original behavior. The qrc stuff looks mostly like last patch, but a bit better commented, while the rest looks more like the original code.

The only behaviourial changes from the original code are that non-local absolute file paths (eg smb share file paths, eg "//hostname/share/path") and "qrc:///" URLs actually works.

I have also added qrc support to the QUrl constructor, and deprecated the QString constructor in favour of it.


QFSFileEngine has been removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome.

Diffs (updated)

  phonon/mediasource.h 5374f00 
  phonon/mediasource.cpp 9e35094 




Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
Kde-frameworks-devel mailing list
Kde-frameworks-devel at

More information about the kde-multimedia mailing list