Review Request: Remove QFSFileEngine useage from Phonon five.

[Harald Sitter]

> On Oct. 20, 2012, 8:23 p.m., David Faure wrote:
> > kcoreaddons has KFileSystemType, to distinguish local from NFS/SMB (which I guess this is what this was about).
> > Maybe it could go into Qt.... I guess for now this is ok (unless we want to use kcoreaddons in phonon, but I doubt that)

Don't think kcoreaddons makes much sense given the importance/impact of that feature ;)

I believe the "proper" fix (if there is one in this case) would be to simply make the string evaluation more elaborate. In particular if does not contain a protocol (something *://) or the protocol is file:// -> local file, if starts with :/ or protocol is qrc:// -> load through QFile, else convert to QUrl and see if it can make sense out of it.

That being said. Earlier history of that code segment only contains the QFSFileEngine so I assume its only use was to distinguish local files from qrc urls, so dropping the QFS part should be just fine in that "if you were throwing proper URLs at the QString constructor you were using the API wrong and if your software is now broken it is not our fault".

I am not favoring either approach although the "proper" fix probably is nicer for the users. In actual Phonon 5 (i.e. changed API) we'll probably have to remove the QString constructor and force people to provide valid URLs, needs discussion though.


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106974/#review20604
-----------------------------------------------------------


On Oct. 20, 2012, 7:49 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106974/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 7:49 p.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> QFSFileEngine has been removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome.
> 
> 
> Diffs
> -----
> 
>   phonon/mediasource.cpp 9e35094 
> 
> Diff: http://git.reviewboard.kde.org/r/106974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121020/f9f26570/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia