Review Request: Always use cmake's internal automoc support.

[Ian Monroe]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106958/#review20590
-----------------------------------------------------------


aren't all the include statements (eg #include "moc_effectwidget.cpp") not needed anymore when using cmake's built-in support for moc? CMake just automatically adds the moc files to the build.

- Ian Monroe


On Oct. 19, 2012, 8:13 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106958/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 8:13 p.m.)
> 
> 
> Review request for Phonon.
> 
> 
> Description
> -------
> 
> Always use cmake's internal automoc support.
> 
> Beginning with version to 2.8.6 CMake have built in automoc support, thus making automoc4 unnecessary. The FindPhononInternal.cmake already uses the built in automoc support if available, but falls back to automoc4 when it isn't. This check will, however, get mighty confused when pressented with Qt5 rather than Qt4, and I figgured it was easier to just bump the required cmake version than to try debug why it didn't work. :P
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ea709f2 
>   cmake/CMakeLists.txt 4a3886c 
>   cmake/FindAutomoc4.cmake e08ae80 
>   cmake/FindPhononInternal.cmake 66b4a21 
>   demos/metadatareader/CMakeLists.txt 0410a1c 
>   demos/phota/CMakeLists.txt b37b4ad 
>   demos/simplecapture/CMakeLists.txt c13715d 
>   demos/simpleplayer/CMakeLists.txt e97bfd3 
> 
> Diff: http://git.reviewboard.kde.org/r/106958/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121020/29421b59/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia