Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106970/#review22580
-----------------------------------------------------------


This review has been submitted with commit 7500c995162ac56dd6217261c355e0351c59dae9 by Jon Severinsson to branch five.

- Commit Hook


On Nov. 3, 2012, 8:26 a.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106970/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2012, 8:26 a.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> This is required for the build system to work with both Qt4 and Qt5.
> 
> Also do a complete overhaul of the build system, in order to look and
> behave more like a regular KF5 tier 1 framework, and less like a
> bastard child of Qt.
> 
> On Qt4 the build system will now insist on "libinqt5" being installed,
> which is located in the kdelibs repository in the frameworks branch.
> There is, however, no dependancy on the actual KDE Frameworks 5, and
> libinqt5 can be build and installed standalone.
> 
> 
> Diffs
> -----
> 
>   cmake/FindQt4.cmake 75aa34c 
>   abi-check-install.sh.cmake 4296976 
>   cmake/CMakeLists.txt 7574b42 
>   cmake/FindPackageHandleStandardArgs.cmake 7f122ed 
>   cmake/FindPhononInternal.cmake ae996b9 
>   CTestConfig.cmake 04f21dc 
>   PhononConfig.cmake.in c6f5eb9 
>   PhononConfigVersion.cmake.in 3ee860b 
>   CMakeLists.txt ed09836 
>   cmake/MacroEnsureVersion.cmake 6797e5b 
>   cmake/MacroPushRequiredVars.cmake 650b566 
>   cmake/PhononMacros.cmake 2158058 
>   cmake/Qt4ConfigDependentSettings.cmake b5462e7 
>   cmake/Qt4Macros.cmake 1422c59 
>   cmake/cmake_uninstall.cmake.in 7e36ed4 
>   declarative/CMakeLists.txt 10ea4ad 
>   declarative/qml/CMakeLists.txt 2753842 
>   demos/CMakeLists.txt 4ef9e58 
>   demos/cmake/FindPhonon.cmake 6b608b1 
>   demos/metadatareader/CMakeLists.txt 397c1d6 
>   demos/phota/CMakeLists.txt 09594d7 
>   demos/simplecapture/CMakeLists.txt 28b9564 
>   demos/simpleplayer/CMakeLists.txt c60ddc9 
>   designer/CMakeLists.txt e4bb64d 
>   doc/CMakeLists.txt 4e4d86b 
>   doc/Doxyfile.cmake.in faaa943 
>   lib-descriptor.xml.cmake 9228a39 
>   phonon.pc.cmake 9c64cfc 
>   phonon/CMakeLists.txt 21a9f0d 
>   phonon/phononnamespace.h.in 999ec17 
>   qt_phonon.pri daf824f 
> 
> Diff: http://git.reviewboard.kde.org/r/106970/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121126/c4bdde60/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel