Review Request: phonon phive core frontend api

[Harald Sitter]

> On Sept. 29, 2012, 12:26 p.m., Matěj Laitl wrote:
> > core/Player.h, lines 42-44
> > <http://git.reviewboard.kde.org/r/106566/diff/1/?file=87102#file87102line42>
> >
> >     aboutToFinish() gone?
> >     
> >     I wanted to comment on aboutToFinish() - it is currently very tricky to use that because currently it is sometimes emitted twice or not at all per one media source. I'd like if the docs would somehow limit this behaviour.

abouttofinish needs an entire redesign... also it needs to be moved to the queue IMHO, as the signal's merit is to queue a new track before the queue runs out

also it definitely needs precise documentation as it will likely become a foreign thread signal. i.e. gstreamer expects the next source to be set while its callback is blocked, so this is pretty much the only signal where we must force direct connections


> On Sept. 29, 2012, 12:26 p.m., Matěj Laitl wrote:
> > core/Queue.h, lines 44-46
> > <http://git.reviewboard.kde.org/r/106566/diff/1/?file=87104#file87104line44>
> >
> >     Eya, is this a symbolic code? Otherwise this looks like it would cut the track if aboutToFinish is emitted prematurely etc.

actually it would not... setting a source is independent of playback (or it should be). so if you have a static playlist you even with phonon4 could do:

run:
connectOnPlaying()
setSource(A)
play()

onPlaying:
connectOnStopped()
setSource(B)

onStopped:
play()


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106566/#review19569
-----------------------------------------------------------


On Sept. 25, 2012, 11:06 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106566/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 11:06 a.m.)
> 
> 
> Review request for Amarok and Phonon.
> 
> 
> Description
> -------
> 
> phonon phive core frontend api
> 
> 
> Diffs
> -----
> 
>   core/AudioDataOutput.h PRE-CREATION 
>   core/AudioDataOutput.cpp PRE-CREATION 
>   core/AudioOutput.h PRE-CREATION 
>   core/AudioOutput.cpp PRE-CREATION 
>   core/BackendCapabilities.h PRE-CREATION 
>   core/BackendCapabilities.cpp PRE-CREATION 
>   core/OutputEffect.h PRE-CREATION 
>   core/OutputEffect.cpp PRE-CREATION 
>   core/Player.h PRE-CREATION 
>   core/Player.cpp PRE-CREATION 
>   core/Queue.h PRE-CREATION 
>   core/Queue.cpp PRE-CREATION 
>   core/Source.h PRE-CREATION 
>   core/Source.cpp PRE-CREATION 
>   core/VideoDataOutput.h PRE-CREATION 
>   core/VideoDataOutput.cpp PRE-CREATION 
>   core/abstract/AbstractAudioOutput.h PRE-CREATION 
>   core/abstract/AbstractAudioOutput.cpp PRE-CREATION 
>   core/abstract/AbstractMediaStream.h PRE-CREATION 
>   core/abstract/AbstractMediaStream.cpp PRE-CREATION 
>   core/abstract/AbstractVideoOutput.h PRE-CREATION 
>   core/abstract/AbstractVideoOutput.cpp PRE-CREATION 
>   core/core.pro PRE-CREATION 
>   core/effects/SubtitleEffect.h PRE-CREATION 
>   core/effects/SubtitleEffect.cpp PRE-CREATION 
>   core/five_global.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121108/10b58b65/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia