[Bug 301887] New: MixDevice::readPlaybackOrCapture appends 'Capture' twice

[John Stanley]

https://bugs.kde.org/show_bug.cgi?id=301887

            Bug ID: 301887
          Severity: normal
           Version: unspecified
          Priority: NOR
          Assignee: kde-multimedia at kde.org
           Summary: MixDevice::readPlaybackOrCapture appends 'Capture'
                    twice
    Classification: Unclassified
                OS: Linux
          Reporter: jpsinthemix at verizon.net
          Hardware: Compiled Sources
            Status: UNCONFIRMED
         Component: general
           Product: kdemultimedia

In method MixDevice::readPlaybackOrCapture we have the code
(kdemultimedia-4.8.4.new/kmix/core/mixdevice.cpp):

293       QString volstr = getVolString(chid,capture);
294        if ( capture ) volstr += "Capture";

but in method  QString MixDevice::getVolString, "Capture" is already appended
if needed:

336 QString MixDevice::getVolString(Volume::ChannelID chid, bool capture)
337 {
338        QString volstr (Volume::ChannelNameForPersistence[chid]);
339        if ( capture ) volstr += "Capture";
340        return volstr;
341 }

so, line 294 is not needed and causes problems by appending "Capture" twice.

Reproducible: Always

Steps to Reproduce:
1. See Details
2.
3.
Actual Results:  
See Fetails

Expected Results:  
See Details

-- 
You are receiving this mail because:
You are the assignee for the bug.