Review Request: Add a typedef for shared_ptr<MixDevice>
Franz Fellner
alpine.art.de at googlemail.com
Tue Jun 5 09:47:55 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105150/
-----------------------------------------------------------
Review request for KDE Multimedia.
Description
-------
This patch simply adds a typedef std::tr1::shared_ptr<MixDevice> to MixDevice::Ptr.
It simplifies the usage and exchange (if needed) of the smartpointer.
Also clean out namespace pollution by various "using namespace std::tr1;" in header files (probably introduced to make transition from std::tr1::shared_ptr to std::shared_ptr easier, as soon as C++11 is a requirement for kde?).
Diffs
-----
apps/kmix.cpp cf4ba33
apps/kmixd.cpp 3c0858d
backends/mixer_alsa.h ebcc708
backends/mixer_alsa9.cpp c3f2086
backends/mixer_backend.h 3b28acb
backends/mixer_backend.cpp 0c97447
backends/mixer_mpris2.h 0a7cb15
backends/mixer_mpris2.cpp 51d78a4
backends/mixer_oss.h 4f2646a
backends/mixer_oss.cpp 5850d9c
backends/mixer_oss4.h ae50931
backends/mixer_oss4.cpp e7de30b
backends/mixer_pulse.h 9f5d105
backends/mixer_pulse.cpp 35b7638
backends/mixer_sun.h 4412e44
backends/mixer_sun.cpp 0ab87bc
core/ControlPool.h 4cb2222
core/ControlPool.cpp f2dd17b
core/MasterControl.h dff9e95
core/mixdevice.h 65d8970
core/mixdevice.cpp 94601e2
core/mixdevicecomposite.h 0180e24
core/mixdevicecomposite.cpp 10e0121
core/mixer.h cbaf6c0
core/mixer.cpp e991f57
core/mixertoolbox.cpp 6782293
core/mixset.h 28b3669
core/mixset.cpp 67cd2c5
dbus/dbuscontrolwrapper.h 5355f97
dbus/dbuscontrolwrapper.cpp e0cccff
dbus/dbusmixerwrapper.cpp 81e7a49
dbus/dbusmixsetwrapper.cpp 5ef3be3
gui/dialogselectmaster.cpp a5e5f45
gui/dialogviewconfiguration.cpp d6492a9
gui/kmixdockwidget.cpp b438173
gui/mdwenum.h ad93d36
gui/mdwenum.cpp 822502e
gui/mdwmoveaction.h acc6e6e
gui/mdwmoveaction.cpp 4fafdf1
gui/mdwslider.h 4dc5bf2
gui/mdwslider.cpp c943848
gui/mixdevicewidget.h 85908ae
gui/mixdevicewidget.cpp 727651a
gui/viewbase.h a143408
gui/viewbase.cpp 7979ba8
gui/viewdockareapopup.h 303ec61
gui/viewdockareapopup.cpp fa01c8c
gui/viewsliders.h 51aa515
gui/viewsliders.cpp d893b8e
Diff: http://git.reviewboard.kde.org/r/105150/diff/
Testing
-------
Compiled fine with all backends (except MIXER_SUN - I don't have such a machine).
Thanks,
Franz Fellner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120605/b8f9ccc7/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list