<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105150/">http://git.reviewboard.kde.org/r/105150/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia.</div>
<div>By Franz Fellner.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch simply adds a typedef std::tr1::shared_ptr<MixDevice> to MixDevice::Ptr.
It simplifies the usage and exchange (if needed) of the smartpointer.
Also clean out namespace pollution by various "using namespace std::tr1;" in header files (probably introduced to make transition from std::tr1::shared_ptr to std::shared_ptr easier, as soon as C++11 is a requirement for kde?).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled fine with all backends (except MIXER_SUN - I don't have such a machine).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>apps/kmix.cpp <span style="color: grey">(cf4ba33)</span></li>
<li>apps/kmixd.cpp <span style="color: grey">(3c0858d)</span></li>
<li>backends/mixer_alsa.h <span style="color: grey">(ebcc708)</span></li>
<li>backends/mixer_alsa9.cpp <span style="color: grey">(c3f2086)</span></li>
<li>backends/mixer_backend.h <span style="color: grey">(3b28acb)</span></li>
<li>backends/mixer_backend.cpp <span style="color: grey">(0c97447)</span></li>
<li>backends/mixer_mpris2.h <span style="color: grey">(0a7cb15)</span></li>
<li>backends/mixer_mpris2.cpp <span style="color: grey">(51d78a4)</span></li>
<li>backends/mixer_oss.h <span style="color: grey">(4f2646a)</span></li>
<li>backends/mixer_oss.cpp <span style="color: grey">(5850d9c)</span></li>
<li>backends/mixer_oss4.h <span style="color: grey">(ae50931)</span></li>
<li>backends/mixer_oss4.cpp <span style="color: grey">(e7de30b)</span></li>
<li>backends/mixer_pulse.h <span style="color: grey">(9f5d105)</span></li>
<li>backends/mixer_pulse.cpp <span style="color: grey">(35b7638)</span></li>
<li>backends/mixer_sun.h <span style="color: grey">(4412e44)</span></li>
<li>backends/mixer_sun.cpp <span style="color: grey">(0ab87bc)</span></li>
<li>core/ControlPool.h <span style="color: grey">(4cb2222)</span></li>
<li>core/ControlPool.cpp <span style="color: grey">(f2dd17b)</span></li>
<li>core/MasterControl.h <span style="color: grey">(dff9e95)</span></li>
<li>core/mixdevice.h <span style="color: grey">(65d8970)</span></li>
<li>core/mixdevice.cpp <span style="color: grey">(94601e2)</span></li>
<li>core/mixdevicecomposite.h <span style="color: grey">(0180e24)</span></li>
<li>core/mixdevicecomposite.cpp <span style="color: grey">(10e0121)</span></li>
<li>core/mixer.h <span style="color: grey">(cbaf6c0)</span></li>
<li>core/mixer.cpp <span style="color: grey">(e991f57)</span></li>
<li>core/mixertoolbox.cpp <span style="color: grey">(6782293)</span></li>
<li>core/mixset.h <span style="color: grey">(28b3669)</span></li>
<li>core/mixset.cpp <span style="color: grey">(67cd2c5)</span></li>
<li>dbus/dbuscontrolwrapper.h <span style="color: grey">(5355f97)</span></li>
<li>dbus/dbuscontrolwrapper.cpp <span style="color: grey">(e0cccff)</span></li>
<li>dbus/dbusmixerwrapper.cpp <span style="color: grey">(81e7a49)</span></li>
<li>dbus/dbusmixsetwrapper.cpp <span style="color: grey">(5ef3be3)</span></li>
<li>gui/dialogselectmaster.cpp <span style="color: grey">(a5e5f45)</span></li>
<li>gui/dialogviewconfiguration.cpp <span style="color: grey">(d6492a9)</span></li>
<li>gui/kmixdockwidget.cpp <span style="color: grey">(b438173)</span></li>
<li>gui/mdwenum.h <span style="color: grey">(ad93d36)</span></li>
<li>gui/mdwenum.cpp <span style="color: grey">(822502e)</span></li>
<li>gui/mdwmoveaction.h <span style="color: grey">(acc6e6e)</span></li>
<li>gui/mdwmoveaction.cpp <span style="color: grey">(4fafdf1)</span></li>
<li>gui/mdwslider.h <span style="color: grey">(4dc5bf2)</span></li>
<li>gui/mdwslider.cpp <span style="color: grey">(c943848)</span></li>
<li>gui/mixdevicewidget.h <span style="color: grey">(85908ae)</span></li>
<li>gui/mixdevicewidget.cpp <span style="color: grey">(727651a)</span></li>
<li>gui/viewbase.h <span style="color: grey">(a143408)</span></li>
<li>gui/viewbase.cpp <span style="color: grey">(7979ba8)</span></li>
<li>gui/viewdockareapopup.h <span style="color: grey">(303ec61)</span></li>
<li>gui/viewdockareapopup.cpp <span style="color: grey">(fa01c8c)</span></li>
<li>gui/viewsliders.h <span style="color: grey">(51aa515)</span></li>
<li>gui/viewsliders.cpp <span style="color: grey">(d893b8e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105150/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>