Review Request: Add MPRIS2 support to JuK
Alex Merry
kde at randomguy3.me.uk
Thu Apr 19 21:01:19 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104681/
-----------------------------------------------------------
Review request for KDE Multimedia and Michael Pyne.
Description
-------
This adds basic support for MPRIS2 to JuK (http://specifications.freedesktop.org/mpris-spec/latest/)
Some (optional) things are still unsupported as I have not figured out how to make them work. Notably, it is not possible to seek, as the naive implementation (calling PlayerManager->seek()) behaves strangely (the existing D-Bus interface doesn't support seeking, either).
The existing collection interface is not replicated. Most things from the existing player interface are implemented in this MPRIS2 interface (I think the only exception is that MPRIS2 does not have an "album random" option).
Diffs
-----
CMakeLists.txt 9bd57f6c08abd9b144b0abc1775702284d6af753
mprisproxy.h PRE-CREATION
mprisproxy.cpp PRE-CREATION
org.mpris.MediaPlayer2.Player.xml PRE-CREATION
org.mpris.MediaPlayer2.xml PRE-CREATION
playermanager.h 0eec655b487c5e0e37856b39e128087038987f05
playermanager.cpp 54f601d19f801327f45b3157ed090aa785370583
volumepopupbutton.h 6fb621b10c9a29f11d66869aac6451ed52935d79
volumepopupbutton.cpp 76bd95d8e8713ace3afcba0ee510fdb19d6777b3
Diff: http://git.reviewboard.kde.org/r/104681/diff/
Testing
-------
Tested using the MPRIS2 tester application (http://github.com/randomguy3/mpristester).
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120419/abdf59e3/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list