Review Request: Add MPRIS2 support to JuK

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104681/#review12687
-----------------------------------------------------------


Thanks, oddly enough Eike Hein also recently contributed some code to support MPRIS2 since Konversation will soon only support that. See http://quickgit.kde.org/index.php?p=clones%2Fjuk%2Fmpyne%2Fjuk-MPRIS.git&a=summary I didn't have a good tester for it though, and it sounds as if you've implemented more of the interfaces (so far we only have the Player interface).

- Michael Pyne


On April 19, 2012, 8:01 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104681/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 8:01 p.m.)
> 
> 
> Review request for KDE Multimedia and Michael Pyne.
> 
> 
> Description
> -------
> 
> This adds basic support for MPRIS2 to JuK (http://specifications.freedesktop.org/mpris-spec/latest/)
>     
> Some (optional) things are still unsupported as I have not figured out how to make them work.  Notably, it is not possible to seek, as the naive implementation (calling PlayerManager->seek()) behaves strangely (the existing D-Bus interface doesn't support seeking, either).
> 
> The existing collection interface is not replicated.  Most things from the existing player interface are implemented in this MPRIS2 interface (I think the only exception is that MPRIS2 does not have an "album random" option).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9bd57f6c08abd9b144b0abc1775702284d6af753 
>   mprisproxy.h PRE-CREATION 
>   mprisproxy.cpp PRE-CREATION 
>   org.mpris.MediaPlayer2.Player.xml PRE-CREATION 
>   org.mpris.MediaPlayer2.xml PRE-CREATION 
>   playermanager.h 0eec655b487c5e0e37856b39e128087038987f05 
>   playermanager.cpp 54f601d19f801327f45b3157ed090aa785370583 
>   volumepopupbutton.h 6fb621b10c9a29f11d66869aac6451ed52935d79 
>   volumepopupbutton.cpp 76bd95d8e8713ace3afcba0ee510fdb19d6777b3 
> 
> Diff: http://git.reviewboard.kde.org/r/104681/diff/
> 
> 
> Testing
> -------
> 
> Tested using the MPRIS2 tester application (http://github.com/randomguy3/mpristester).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120419/5576b7eb/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia