[PATCH] juk: fix showing the items of all the selected playlists.

Michael Pyne mpyne at kde.org
Tue May 24 03:22:04 BST 2011

On Monday, May 23, 2011 03:26:18 Γιώργος Κυλάφας wrote:
> Hi all,
> I noticed that if I had selected two or more playlists on the left
> side of JuK (the PlaylistBox), I could only see the contents of the
> first one to the right side, instead of all of them. At first I though
> this was not implemented, however, after examining the source I found
> out that the functionality existed, through class DynamicPlaylist.
> From what I understand, the reason it did not work was that the
> dynamic playlist was not set up properly upon creation, i.e. it was
> not added to the playlist stack (a QStackedWidget) and eventually the
> latter was complaining that "widget 0x... not contained in stack".
> So, I propose the attached patch. In case it is approved, should I
> apply it to the 4.6 branch as well?

Seems to work fine, and the logic makes sense.

It should be backported to the 4.6 branch as well. I believe I have already 
bumped the version number for JuK in the 4.6 branch, but you'll want to ensure 
that the bugfix gets noted in the 4.6 branch changelog.

Doing that involves checking out trunk/www/sites/www/announcements/changelogs 
from svn, updating changelog_branch_4_6.xml, and then in theory just running 
"./generate_changelog 4.6.4" (the script in the same directory) should apply 
the changes to the PHP so you can use svn diff to compare. Assuming everything 
looks OK you can just commit from there. Kind of annoying sometimes to handle 
admin, but it helps the marketing/promotion types when making the press 
releases for a new version.

 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110523/b443e447/attachment.sig>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at kde.org

More information about the kde-multimedia mailing list