RFC: Refactor CD player logic from kscd

[Richard Lärkäng]

Hi!

On Monday 21 March 2005 06.12, Shaheed wrote:
> First commit landed for refactored kscd (new class: KCompactDisc). Let me
> know if you see regressions...

It looks quite nice to get the cd-handling moved out to a separate class, and 
the interface looks quite nice.

Do you think it could be used by kaudiocreator too? I don't know where it 
should be placed if it is though.

But I'm afraid the commit introduced some regressions. It doesn't seem to 
respect the digital playback setting. Is the attached patch OK?

Also, when starting kscd with no disc in, it crashes for me. I've attached the 
backtrace.

And when a disc is played and you change to another one, it doesn't clear the 
track-list while it's empty.

> Thanks, Shaheed

Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: digitial-playback.patch
Type: text/x-diff
Size: 584 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20050322/9595e808/attachment.patch>
-------------- next part --------------
Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 16384 (LWP 19533)]
[KCrash handler]
#5  0x080723ab in KCompactDisc::trackLength (this=0x82a2ed0, track=0)
    at /home/richard/kde-cvs/cvs/kdemultimedia/kscd/kcompactdisc.cpp:291
#6  0x08072386 in KCompactDisc::trackLength (this=0x82a2ed0)
    at /home/richard/kde-cvs/cvs/kdemultimedia/kscd/kcompactdisc.cpp:286
#7  0x080728e2 in KCompactDisc::timerExpired (this=0x82a2ed0)
    at /home/richard/kde-cvs/cvs/kdemultimedia/kscd/kcompactdisc.cpp:375
#8  0x08072fad in KCompactDisc::qt_invoke (this=0x82a2ed0, _id=2, 
    _o=0xbfffe870) at kcompactdisc.moc:189
#9  0xb70a9eb7 in QObject::activate_signal (this=0x82a2ef8, clist=0x82a3118, 
    o=0xbfffe870) at qobject.cpp:2355
#10 0xb70a9d5a in QObject::activate_signal (this=0x82a2ef8, signal=2)
    at qobject.cpp:2324
#11 0xb74198c0 in QTimer::timeout (this=0x82a2ef8) at moc_qtimer.cpp:82
#12 0xb70cfd52 in QTimer::event (this=0x82a2ef8, e=0xbfffeb00)
    at qtimer.cpp:219
#13 0xb7045291 in QApplication::internalNotify (this=0xbfffedb0, 
    receiver=0x82a2ef8, e=0xbfffeb00) at qapplication.cpp:2635
#14 0xb70447d2 in QApplication::notify (this=0xbfffedb0, receiver=0x82a2ef8, 
    e=0xbfffeb00) at qapplication.cpp:2358
#15 0xb76c4040 in KApplication::notify (this=0xbfffedb0, receiver=0x82a2ef8, 
    event=0xbfffeb00)
    at /home/richard/kde-cvs/cvs/kdelibs/kdecore/kapplication.cpp:549
#16 0xb6fd5d7e in QApplication::sendEvent (receiver=0x82a2ef8, 
    event=0xbfffeb00) at qapplication.h:491
#17 0xb70335ac in QEventLoop::activateTimers (this=0x8215fe8)
    at qeventloop_unix.cpp:556
#18 0xb6fe9c46 in QEventLoop::processEvents (this=0x8215fe8, flags=4)
    at qeventloop_x11.cpp:389
#19 0xb705a55b in QEventLoop::enterLoop (this=0x8215fe8) at qeventloop.cpp:198
#20 0xb705a476 in QEventLoop::exec (this=0x8215fe8) at qeventloop.cpp:145
#21 0xb70453fd in QApplication::exec (this=0xbfffedb0) at qapplication.cpp:2758
#22 0x080687ab in main (argc=1, argv=0xbfffefb4)
    at /home/richard/kde-cvs/cvs/kdemultimedia/kscd/kscd.cpp:1642
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia