[PATCH] kcmaudiocd - Ogg Vorbis settings

[Jason Lane]

Hi!

Hope the attached patch against current HEAD is useful...

I wanted to 'Oggify' some CD's this evening, and came across the problem 
described in bug 45352 ("incorrect bitrate when ripping to .ogg") and 
possibly other bugs. The audiocd ioslave now has functionality for using the 
Vorbis quality parameter as well as selecting bitrates, unfortunately the new 
default settings in kcmaudiocdrc ensure that the settings in the control 
panel module have no effect - and audiocd converts at about 100kbps :-(

Anyway, this patch fixes this unfriendly behaviour, by allowing the user to 
encode either by 'quality' or 'bitrate'.

I don't have CVS access, so if it's useful and I've not introduced any new 
bugs into kcmaudiocd, or broken any feature freezes, then feel free to commit 
it. It should work for Vorbis RC3+ and by selecting the bitrate option only, 
should work for earlier versions of Vorbis, too

One issue I have noticed while testing it, is that audiocd appears only to use 
the bitrate to estimate the file sizes -- changing the quality variable has 
no effect on the file list when viewing the Ogg files in Konqueror, and leads 
to odd results in the file copy progress window. However, the resulting Oggs 
are correct -- as verified by ogginfo. I could have a look at this, but it'll 
have to wait until tomorrow evening...

Regards,

Jason
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-kcmaudiocd.patch.bz2
Type: application/x-bzip2
Size: 2450 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20020829/9e03095a/attachment.bin>