D4929: DrKonqi : lldb and Mac support

[René J.V. Bertin]

rjvbb added a comment.


  > That'll probably be when we move to Qt6.
  
  Which is something I hope will be as far in the future as possible :)
  
  but
  
  > I doubt it really would make anyone's lives easier.
  
  Moving something outside of what I secretly call the Plasma jealousy universe should make life a bit easier for those who now have to argue why they'd want to use it. I can (kind of) understand why certain Plasma code would want to use the latest Qt5 version and almost why that version would be standardised across all Plasma members even though not necessary at all. So there's that too.
  
  > Can you explain why you detach?  Work to just call quit in the script to solve the hanging issue?
  
  In a nutshell, detaching before quitting makes the chance of hanging a lot smaller and speeds up the quitting too in my experience.
  
  As I said, I can make the variable backend-agnostic if you think that's preferable. But maybe it could be a nice junior job or GSoC project to redesign the backend so that DrKonqi doesn't have to wait for the debugger to quit. With both gdb and lldb it should be possible to obtain a reloaded backtrace from the same debugger instance, and that refreh should be a lot faster if you don't have to wait for a new debugger instance to start and churn through all loaded libraries - and I'm guessing that there will be no hanging issues when you quit lldb at DrKonqi's exit.
  And if so, keeping the backend-specific variable where it is could serve as a nice little reminder.

INLINE COMMENTS

> davidedmundson wrote in aboutbugreportingdialog.cpp:39
>   icon = QIcon::fromTheme
>   if (icon.isValid()) {
>      setWindowIcon(...)
>   }
> 
> is more standard..
> 
> Though from the docs:
> 
> > Note: On macOS, the window title bar icon is meant for windows representing documents, and will only show up if a file path is also set.
> 
> We don't set this, is this an issue?

Hmmm, this may have changed after I developed the brunt of this patch (in KDE4 days). To answer your question, no, it's not a problem.
I'll have to look at this again, to see if this and similar changes still make sense.

> davidedmundson wrote in backtracegenerator.cpp:140
> this seems dangerous for the other clients.
> 
> It's not unfeasible for a process to have a load of data still in the buffer when it quits.
> 
> I don't know lldb, but it seems you can probably move this to ~149

You mean move the check on QProcess::Running into the `if (line.startsWith(QLatin1String("Process ")) && line.endsWith(QLatin1String(" detached")))` ?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20181123/0fb92bbe/attachment.html>