Review Request 123353: [OS X] Make ktimetracker build and fully functional

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123353/
-----------------------------------------------------------

(Updated nov. 13, 2017, 9:40 après-midi)


Status
------

This change has been discarded.


Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.


Repository: kdepim


Description
-------

A while ago I created a RR for ktimetracker on OS X (https://git.reviewboard.kde.org/r/119533/) which was either never committed (despite a "Ship It") or which was reverted at a later stage. I therefore re-submit the patch with updates.

I have now a better fix for the failing dynamic_cast in mainwindow.cpp . The cast itself continues to fail despite ensuring that `ktimetrackerpart` is exported. It appears not to be required on OS X, however.
The idle time detection code for OS X has not been changed.


Diffs
-----

  ktimetracker/CMakeLists.txt bf7b0ef 
  ktimetracker/idletimedetector.h 524f739 
  ktimetracker/idletimedetector.cpp 250dda5 
  ktimetracker/ktimetrackerpart.h 95da43b 
  ktimetracker/ktimetrackerpart_export.h PRE-CREATION 
  ktimetracker/ktimetrackerutility.cpp efeba3a 
  ktimetracker/mainwindow.cpp 56d4c28 


Diff: https://git.reviewboard.kde.org/r/123353/diff/1/


Testing
-------

On OS X 10.9.5 with kdelibs 4.14.5


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20171113/2824edf0/attachment.html>