<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123353/">https://git.reviewboard.kde.org/r/123353/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><em>Updated nov. 13, 2017, 9:40 après-midi</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
kdepim
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A while ago I created a RR for ktimetracker on OS X (https://git.reviewboard.kde.org/r/119533/) which was either never committed (despite a "Ship It") or which was reverted at a later stage. I therefore re-submit the patch with updates.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have now a better fix for the failing dynamic_cast in mainwindow.cpp . The cast itself continues to fail despite ensuring that <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ktimetrackerpart</code> is exported. It appears not to be required on OS X, however.
The idle time detection code for OS X has not been changed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.9.5 with kdelibs 4.14.5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ktimetracker/CMakeLists.txt <span style="color: grey">(bf7b0ef)</span></li>
<li>ktimetracker/idletimedetector.h <span style="color: grey">(524f739)</span></li>
<li>ktimetracker/idletimedetector.cpp <span style="color: grey">(250dda5)</span></li>
<li>ktimetracker/ktimetrackerpart.h <span style="color: grey">(95da43b)</span></li>
<li>ktimetracker/ktimetrackerpart_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ktimetracker/ktimetrackerutility.cpp <span style="color: grey">(efeba3a)</span></li>
<li>ktimetracker/mainwindow.cpp <span style="color: grey">(56d4c28)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123353/diff/1/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>