Review Request 129363: reliability fixes

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129363/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 6:39 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Software on Mac OS X and Yichao Yu.


Changes
-------

Submitted with commit f393eb097135667946e43011cdb9a233045cb9a8 by R.J.V. Bertin to branch master.


Repository: qtcurve


Description
-------

I've been making a number of fixes to QtCurve recently, mostly to improve the reliability of its settings management. The current set of fixes is getting a bit complex and thus something I'd rather put up for review while I work on it.

The leitmotiv is: read and write all settings all the time, even if you don't use everything. This prevents settings getting lost.

This approach is all the more important since I've restored the support for a system-wide stylerc file. For now that's a MacPorts patch, but I'd be happy to include it here if it's considered of general use.


Diffs
-----

  .reviewboardrc PRE-CREATION 
  qt4/common/config_file.cpp 7a0a6bc 
  qt4/config/qtcurveconfig.cpp 740150f 
  qt4/style/qtcurve.cpp 5447e07 
  qt5/common/config_file.cpp 7630f4e 
  qt5/config/qtcurveconfig.cpp df8ce89 
  qt5/style/qtcurve.cpp 4457def 

Diff: https://git.reviewboard.kde.org/r/129363/diff/


Testing
-------

Being tested on Mac and Linux with QtCurve the main style.


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20161129/5ecaf99a/attachment.html>