[KDE/Mac] Review Request 127896: make dbus optional on osx: kauth

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127896/#review95394
-----------------------------------------------------------




src/CMakeLists.txt (line 32)
<https://git.reviewboard.kde.org/r/127896/#comment64677>

    In theory - nothing in KAuth should be using DBus outside of the helpers.
    (and that autotest that uses the helper)
    
    You should be able to make this change unconditionally - and move finding DBus to src/ConfigureChecks cmake
    
    Then we can change those autotests to use the right backend depending on which backend get built - which is more semantically correct.
    
    Otherwise we still have a problem that I can manually select the fake backend via KAUTH_HELPER_BACKEND_NAME, yet still end up using a test requiring DBus for something that isn't being built.


- David Edmundson


On May 20, 2016, 9:13 p.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127896/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 9:13 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and Martin Gräßlin.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> this is the first patch to make kde frameworks build (and then work) without dbus.
> 
> this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a common service in osx world, kde apps on osx should use native means for interprocess communication instead -- this will make them better citizens in osx ecosystem.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 48dc2d9 
>   autotests/BackendsManager.cpp 59675b3 
>   autotests/CMakeLists.txt b53d760 
>   autotests/HelperTest.cpp 8050a06 
>   src/CMakeLists.txt 1b6930d 
>   src/ConfigureChecks.cmake d46761a 
> 
> Diff: https://git.reviewboard.kde.org/r/127896/diff/
> 
> 
> Testing
> -------
> 
> compiles fine on osx, compiles fine on linux, tests on linux still pass.
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160521/a571940a/attachment-0001.html>