Review Request 128358: QtCurve-qt5 : start weaning off KDELibs4Support

René J.V. Bertin rjvbertin at gmail.com
Wed Aug 10 08:57:24 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128358/
-----------------------------------------------------------

(Updated Aug. 10, 2016, 8:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Software on Mac OS X and Yichao Yu.


Changes
-------

Submitted with commit 2f6417f66f032943d8d344288b82ff0a2f081a19 by René J.V. Bertin to branch master.


Repository: qtcurve


Description
-------

The title says it all; QtCurve should be weaned off KDELibs4Support.
This first step uses current APIs for the KDE4 APIs that have been deprecated explicitly.


Diffs
-----

  qt5/style/qtcurve.h d9395bc 
  qt5/style/qtcurve.cpp 929ec81 
  qt5/style/qtcurve_api.cpp 4e95e15 
  qt5/style/qtcurve_primitive.cpp 758fdf1 
  qt5/style/windowmanager.cpp 225d363 

Diff: https://git.reviewboard.kde.org/r/128358/diff/


Testing
-------

On OS X and Linux with Qt 5.6.1

I think it'd be important for this ticket if 1 or 2 others test the patch on their end to be sure we've had reasonable coverage of the rather large settings space before we commit anything.


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160810/b5145106/attachment.html>


More information about the kde-mac mailing list