Review Request 128358: QtCurve-qt5 : start weaning off KDELibs4Support

[René J.V. Bertin]

> On July 25, 2016, 5:14 p.m., Yichao Yu wrote:
> > LGTM.
> > 
> > Just to make sure, the ones that replaces KDE settings with Qt ones are now sync'd to the Qt settings on Qt5 right?

I'm not sure what you mean here; it seems the answer to that question can only be "yes". In practice, I've only addressed deprecated APIs; accessing KDE settings through the current mechanisms rather than KDELibs4Support ones.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128358/#review97835
-----------------------------------------------------------


On July 4, 2016, 8:42 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128358/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 8:42 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Yichao Yu.
> 
> 
> Repository: qtcurve
> 
> 
> Description
> -------
> 
> The title says it all; QtCurve should be weaned off KDELibs4Support.
> This first step uses current APIs for the KDE4 APIs that have been deprecated explicitly.
> 
> 
> Diffs
> -----
> 
>   qt5/style/qtcurve.h d9395bc 
>   qt5/style/qtcurve.cpp 929ec81 
>   qt5/style/qtcurve_api.cpp 4e95e15 
>   qt5/style/qtcurve_primitive.cpp 758fdf1 
>   qt5/style/windowmanager.cpp 225d363 
> 
> Diff: https://git.reviewboard.kde.org/r/128358/diff/
> 
> 
> Testing
> -------
> 
> On OS X and Linux with Qt 5.6.1
> 
> I think it'd be important for this ticket if 1 or 2 others test the patch on their end to be sure we've had reasonable coverage of the rather large settings space before we commit anything.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160810/3e2ed145/attachment.html>