[KDE/Mac] Review Request 126069: [OS X] better integration of the cross-platform wallet runtime

René J.V. Bertin rjvbertin at gmail.com
Mon Nov 16 11:59:56 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 16, 2015, 12:59 p.m.)

Review request for KDE Software on Mac OS X and KDE Frameworks.


Made the CMake file changes platform non-specific.
Including `ECMMarkNonGuiExecutable` one level up should make `ecm_mark_nongui_executable` available downstream, right?

Repository: kwallet


Pending an overdue update to my OS X Keychain backend, this patch provides better integration of the runtime:

- kwallet-query and kwalletd5 are built as regular executables, not app bundles, making them easier to find via the shell and KService
- kwalletd5 is modified to run as an agent, meaning it doesn't show up in the Dock or App Switcher.

Diffs (updated)

  src/runtime/CMakeLists.txt f3f2798 
  src/runtime/kwallet-query/src/CMakeLists.txt 9ab9d9d 
  src/runtime/kwalletd/CMakeLists.txt ba9e7ba 
  src/runtime/kwalletd/main.cpp dd959b6 

Diff: https://git.reviewboard.kde.org/r/126069/diff/


On OS X 10.9 with Qt 5.5.0, in the 5.15.0 frameworks release version.


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151116/3b26b75c/attachment.html>

More information about the kde-mac mailing list