[KDE/Mac] Review Request 126069: [OS X] better integration of the cross-platform wallet runtime

[René J.V. Bertin]

> On Nov. 15, 2015, 12:33 a.m., Aleix Pol Gonzalez wrote:
> > src/runtime/kwallet-query/src/CMakeLists.txt, line 20
> > <https://git.reviewboard.kde.org/r/126069/diff/1/?file=416871#file416871line20>
> >
> >     Why only for APPLE?
> 
> René J.V. Bertin wrote:
>     Mostly because I didn't want to pretend to know the side-effects this could have on platforms other than Linux and OS X ...
> 
> Aleix Pol Gonzalez wrote:
>     That's not how it works. You don't improve kwallet on OS X, you improve it everywhere. That's why it's a framework.
>     
>     Also given the nature of `ecm_mark_nongui_executable` I don't see a problem with having it on every platform. I can see how it can be useful on other platforms, in fact. We need to minimize platfrom-specific code if we want to have a viable cross-platform solution.

That reads as if I shouldn't bothering to improve the code on OS X if I don't also know how to improve it elsewhere, but somehow I don't think you wanted to say that. :)

The term `ecm_mark_nongui_executable` is not a happy choice, at least not on OS X where it only prevents the creation of an app bundle around the actual executable. That doesn't prevent the application from putting up a GUI at all, while the function suggests that is what could happen on other platforms. If you think that's not the case, then fine, I'll remove the conditional aspect.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126069/#review88366
-----------------------------------------------------------


On Nov. 14, 2015, 10:29 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126069/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 10:29 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Pending an overdue update to my OS X Keychain backend, this patch provides better integration of the runtime:
> 
> - kwallet-query and kwalletd5 are built as regular executables, not app bundles, making them easier to find via the shell and KService
> - kwalletd5 is modified to run as an agent, meaning it doesn't show up in the Dock or App Switcher.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwallet-query/src/CMakeLists.txt 9ab9d9d 
>   src/runtime/kwalletd/CMakeLists.txt ba9e7ba 
>   src/runtime/kwalletd/main.cpp dd959b6 
> 
> Diff: https://git.reviewboard.kde.org/r/126069/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9 with Qt 5.5.0, in the 5.15.0 frameworks release version.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20151116/7230d2e4/attachment.html>