[KDE/Mac] Review Request 123876: missing initialisation of PageViewPrivate::aFitWindowToPage

René J.V. Bertin rjvbertin at gmail.com
Thu May 21 23:47:25 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated May 21, 2015, 11:47 p.m.)


This change has been marked as submitted.

Review request for KDE Software on Mac OS X and Okular.


Submitted with commit 42e03ce9bf6ec9d4c7f1c19c10a14c886dbd7427 by René J.V. Bertin to branch master.

Repository: okular


`PageViewPrivate::aFitWindowToPage` isn't initialised to NULL like `aMouseMagnifier` is, and this leads to jumping to an uninitialised address when `aFitWindowToPage->setEnabled()` is called.

This patch initialises the member to NULL, and adds a check in `PageView::slotRelayoutPages()`.


  ui/pageview.cpp b57e6ae 

Diff: https://git.reviewboard.kde.org/r/123876/diff/


On OS X 10.9 with kdelibs 4.14.7 and Qt 4.8.7 . This patch prevents a crash that would otherwise occur quickly after doing File/Print Preview.


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150521/326577df/attachment.html>

More information about the kde-mac mailing list