[KDE/Mac] Review Request 123876: missing initialisation of PageViewPrivate::aFitWindowToPage

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123876/#review80715
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Whiting


On May 21, 2015, 3:24 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123876/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 3:24 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> `PageViewPrivate::aFitWindowToPage` isn't initialised to NULL like `aMouseMagnifier` is, and this leads to jumping to an uninitialised address when `aFitWindowToPage->setEnabled()` is called.
> 
> This patch initialises the member to NULL, and adds a check in `PageView::slotRelayoutPages()`.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp b57e6ae 
> 
> Diff: https://git.reviewboard.kde.org/r/123876/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9 with kdelibs 4.14.7 and Qt 4.8.7 . This patch prevents a crash that would otherwise occur quickly after doing File/Print Preview.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150521/75a975ea/attachment.html>