[KDE/Mac] Review Request 122757: [OS X] malloc.h lives in /usr/include/sys

[René J.V. Bertin]

> On March 1, 2015, 1:04 a.m., Andreas Pakulat wrote:
> > parser/astbuilder.cpp, line 28
> > <https://git.reviewboard.kde.org/r/122757/diff/1/?file=352392#file352392line28>
> >
> >     Hmm, my malloc manpage tells me to use stdlib.h not malloc.h. Did you check wether history of the file tells you that malloc.h was used intentionally? And the mac I have access to seems to have a malloc declaration in stdlib.h too, so that way one could avoid the ifdef.

No, I didn't check the history - yet. I'd have done that (or otherwise looked into whether the header is required) if OS X hadn't had a malloc.h, or one that caused errors itself.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122757/#review76788
-----------------------------------------------------------


On Feb. 28, 2015, 5:57 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122757/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2015, 5:57 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> On OS X, the malloc.h header file must be included as `<sys/malloc.h>` .
> 
> 
> Diffs
> -----
> 
>   parser/astbuilder.cpp e914877 
> 
> Diff: https://git.reviewboard.kde.org/r/122757/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5/MacPorts.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150301/178b1004/attachment.html>