[KDE/Mac] Review Request 122756: [OS X] buildsystem: find python3 executable and libraries
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Mar 1 00:41:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122756/#review76789
-----------------------------------------------------------
CMakeLists.txt
<https://git.reviewboard.kde.org/r/122756/#comment52859>
${kdevpython_SOURCE_DIR}/cmake and ${CMAKE_SOURCE_DIR}/cmake/modules seems to be the same.
CMakeLists.txt
<https://git.reviewboard.kde.org/r/122756/#comment52860>
Why is a separate finder needed? It seems like it was already looking for python 3.0.
Can we maybe fix PythonInterp?
parser/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122756/#comment52861>
Same thing
- Aleix Pol Gonzalez
On Feb. 28, 2015, 5:55 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122756/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 5:55 p.m.)
>
>
> Review request for KDE Software on Mac OS X and KDevelop.
>
>
> Repository: kdev-python
>
>
> Description
> -------
>
> I encountered issues trying to configure kdev-python v1.7.1-py3 on OS X to build against MacPorts: the build system didn't pick up the correct Python version.
>
> Someone on the CMake ML pointed me to Python3-specific versions of CMake's FindPython modules, and after some adaptation those seem to do the trick.
>
>
> Diffs
> -----
>
> CMakeLists.txt 18ecfc0
> cmake/CMakeLists.txt PRE-CREATION
> cmake/modules/FindPython3Interp.cmake PRE-CREATION
> cmake/modules/FindPython3Libs.cmake PRE-CREATION
> parser/CMakeLists.txt 1058d76
>
> Diff: https://git.reviewboard.kde.org/r/122756/diff/
>
>
> Testing
> -------
>
> On OS X 10.9.5/MacPorts.
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150301/fe0fae01/attachment.html>
More information about the kde-mac
mailing list