[KDE/Mac] Review Request 122277: Improve the version (and copyright) information display in KDE/KF5 systemsettings

René J.V. Bertin rjvbertin at gmail.com
Tue Jan 27 20:13:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122277/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 9:13 p.m.)


Review request for KDE Software on Mac OS X and Yichao Yu.


Repository: qtcurve


Description
-------

Configuring QtCurve through the KDE systemsettings application shows version and copyright information that isn't very informative nor up to date.

This patch appends the git commit tag to the version when building in a git working copy, and also adds the name of the current (main) developer to give credit where credit is due!


Diffs (updated)
-----

  CMakeLists.txt b35a7cc 
  qt4/config/qtcurveconfig.cpp f3e010c 
  qt5/config/qtcurveconfig.cpp 5871ac5 

Diff: https://git.reviewboard.kde.org/r/122277/diff/


Testing
-------

On OS X 10.9.5 against Qt4/KDE (4.14.4), Qt 5.4.0 and GTk2 (all through MacPorts).


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150127/cca925a8/attachment.html>


More information about the kde-mac mailing list